-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not default gasLimit to 1M #169
Comments
I checked a few block party contracts and found that most of them hang around ~150K gas and can be near 170K in some cases:
It's best to warn users about the gas limit on the web page and suggest limit around 200K. |
Some of the admin functions may cost over 1M so the alternative is to hard code gas limit per function. https://github.com/makoto/blockparty/blob/master/log/stress_0100.log The inefficiency of admin gas cost is something we are tracking separately #160 |
I guess I can make it constant if I hash the input. Removing these fields are topic of their own. |
I discussed solution here for constant gas cost: #171 |
It's currently set here
https://github.com/makoto/blockparty/blob/master/src/index.js#L224
Which gives heart attack to some users.
https://twitter.com/vietlq/status/1019509916321636352
The ideal solution would be to use estimated gas price (unless most wallet dynamically calculate in which case we can completely take out )
The text was updated successfully, but these errors were encountered: