From f503b2b012a3d6f4a24f8e530ffe70302211dddf Mon Sep 17 00:00:00 2001 From: Pavel Zwerschke Date: Thu, 14 Dec 2023 17:24:54 +0100 Subject: [PATCH] Make incorrect condarc only a warning --- .github/workflows/test.yml | 11 +++++++++++ dist/index.js | 2 +- dist/post.js | 2 +- package.json | 2 +- src/options.ts | 2 +- test/condarc.yml | 2 ++ 6 files changed, 17 insertions(+), 4 deletions(-) create mode 100644 test/condarc.yml diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4a5754b..3af9935 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -323,6 +323,17 @@ jobs: which micromamba | grep not-on-path/bin shell: bash -elo pipefail {0} + incorrect-condarc: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: ./ + with: + condarc-file: test/condarc.yml + - run: | + micromamba search pytorch + shell: bash -elo pipefail {0} + # not properly testable # https://github.com/actions/runner/issues/2347 # https://github.com/orgs/community/discussions/15452 diff --git a/dist/index.js b/dist/index.js index ba29ea4..532a53e 100644 --- a/dist/index.js +++ b/dist/index.js @@ -83526,7 +83526,7 @@ var checkForKnownIssues = (options2) => { ); } if (options2.condarcFile && path.basename(options2.condarcFile) !== ".condarc") { - throw new Error( + core2.warning( `You are using a condarc file that is not named '.condarc'. This is currently not supported by micromamba, see https://github.com/mamba-org/mamba/issues/1394` ); } diff --git a/dist/post.js b/dist/post.js index 4cfc8e9..ebdc768 100644 --- a/dist/post.js +++ b/dist/post.js @@ -78790,7 +78790,7 @@ var checkForKnownIssues = (options2) => { ); } if (options2.condarcFile && path.basename(options2.condarcFile) !== ".condarc") { - throw new Error( + core.warning( `You are using a condarc file that is not named '.condarc'. This is currently not supported by micromamba, see https://github.com/mamba-org/mamba/issues/1394` ); } diff --git a/package.json b/package.json index a4c6a5b..32f9378 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "setup-micromamba", - "version": "1.7.1", + "version": "1.7.2", "private": true, "description": "Action to setup micromamba", "scripts": { diff --git a/src/options.ts b/src/options.ts index 5921a49..52e5651 100644 --- a/src/options.ts +++ b/src/options.ts @@ -225,7 +225,7 @@ const checkForKnownIssues = (options: Options) => { ) } if (options.condarcFile && path.basename(options.condarcFile) !== '.condarc') { - throw new Error( + core.warning( `You are using a condarc file that is not named '.condarc'. This is currently not supported by micromamba, see https://github.com/mamba-org/mamba/issues/1394` ) } diff --git a/test/condarc.yml b/test/condarc.yml new file mode 100644 index 0000000..f2a64be --- /dev/null +++ b/test/condarc.yml @@ -0,0 +1,2 @@ +channels: + - pytorch