Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VM-Install-With-Installer #1195

Open
Ana06 opened this issue Dec 10, 2024 · 0 comments
Open

Improve VM-Install-With-Installer #1195

Ana06 opened this issue Dec 10, 2024 · 0 comments
Labels
💎 enhancement It is working, but it could be better

Comments

@Ana06
Copy link
Member

Ana06 commented Dec 10, 2024

Details

Many of the tools using VM-Install-With-Installer have this pattern:

$toolDir = Join-Path ${Env:RAW_TOOLS_DIR} $toolName
$executablePath = (Join-Path $toolDir "$toolName.exe")
VM-Install-With-Installer $toolName $category "EXE" $silentArgs /Dir=`"$($toolDir)`"" $executablePath $zipUrl -sha256 $zipSha256

Can we use them as defaults to remove this duplication in the packages?

@Ana06 Ana06 added the 💎 enhancement It is working, but it could be better label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better
Projects
None yet
Development

No branches or pull requests

1 participant