Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MANIFEST.MF instead of ez-vcard.properties to get Maven properties #64

Open
stonio opened this issue Sep 6, 2016 · 1 comment
Open

Comments

@stonio
Copy link
Contributor

stonio commented Sep 6, 2016

Java class ezvcard.Ezvcard currently parses file ez-vcard.properties to initialize constant values (VERSION, GROUP_ID, ARTIFACT_ID and URL).

However, we could easily get these values from file MANIFEST.MF . Example to retreive project version:

VERSION = Ezvcard.class.getPackage().getImplementationVersion();

Have you already studied this solution?

References:

@mangstadt
Copy link
Owner

Didn't know about that, thanks for the info.

Don't think the MANIFEST.MF approach would work, since ez-vcard generates an OSGi bundle. All the manifest attribute names start with "Bundle".

pom.properties is nice, but it doesn't have the project URL in it. Plus, you have to know what the project's groupId and artifactId are in order to get the path to the file. What's even the point of putting these in the file if you have to know them in order to get the path to the file??

I think I may stick with the filtered property file approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants