Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globe: Flickering and missing layers when panning/zooming #5025

Open
zerda-ocm opened this issue Nov 9, 2024 · 14 comments
Open

Globe: Flickering and missing layers when panning/zooming #5025

zerda-ocm opened this issue Nov 9, 2024 · 14 comments
Labels
bug Something isn't working globe Globe related issues PR is more than welcomed Extra attention is needed showstopper Preventing from releasing a pre-release version as non-pre-release

Comments

@zerda-ocm
Copy link

zerda-ocm commented Nov 9, 2024

maplibre-gl-js version: 5.0.0-pre.6

browser: bing, chrome

Steps to Trigger Behavior

  1. create a vector map with line layers
  2. set projection to globe
  3. zoom or move around

Link to Demonstration

https://jsbin.com/zusijan/edit?html,output

bandicam.2024-11-09.15-23-26-826.mp4

Expected Behavior

No flickering and complete drawing of layers.

Actual Behavior

This bug is apparently present since the merge of #3983

@birkskyum birkskyum added the globe Globe related issues label Nov 9, 2024
@HarelM
Copy link
Collaborator

HarelM commented Nov 9, 2024

You have linked an issue and not a PR. The relevant PR is:
#4779

Please create a minimal reproduction of this issue, as the linked jsbin contains a lot of complicated logic around tile loading...

@HarelM HarelM added the need more info Further information is requested label Nov 9, 2024
@HarelM
Copy link
Collaborator

HarelM commented Nov 9, 2024

Cc: @NathanMOlson

@zerda-ocm
Copy link
Author

Please create a minimal reproduction of this issue, as the linked jsbin contains a lot of complicated logic around tile loading...

https://jsbin.com/jakoxob/edit?html,console,output

@HarelM
Copy link
Collaborator

HarelM commented Nov 9, 2024

This style still has too many layers, can you simplify it, and hopefully revive the PMTiles related code (as those can introduce noise)?

@birkskyum
Copy link
Member

birkskyum commented Nov 9, 2024

It looks a lot like z-fighting to me. Could be some subdivision issue

@birkskyum
Copy link
Member

Do we see issues only with the line layer?

@zerda-ocm
Copy link
Author

This style still has too many layers, can you simplify it, and hopefully revive the PMTiles related code (as those can introduce noise)?

I will try to replicate this with some geojson, but that will take some time.

@zerda-ocm
Copy link
Author

Do we see issues only with the line layer?

I haven't seen this issue with other layer types.

russss added a commit to openinframap/openinframap that referenced this issue Nov 9, 2024
@russss
Copy link

russss commented Nov 9, 2024

I'm also seeing this issue on OpenInfraMap, which isn't using PMTiles. I believe it's only happening on line layers.

@birkskyum
Copy link
Member

I do see some flickering in mercator projection too:

Screen.Recording.2024-11-09.at.22.08.09.mov

@zerda-ocm
Copy link
Author

zerda-ocm commented Nov 10, 2024

Demo with geojson as a source and just a few line-layers.
https://jsbin.com/novugaxewo/edit?html,console,output

Fewer layers seemingly makes it a little bit harder for the bug to show up, but zooming in on one of the lines should work.

@HarelM
Copy link
Collaborator

HarelM commented Nov 10, 2024

Can you add a video of the problem in the latest shared jsbin? I'm not sure I can't see the issue...

@birkskyum
Copy link
Member

I zoomed in quite far, and got this:

Screen.Recording.2024-11-10.at.15.06.04.mov

@HarelM HarelM added bug Something isn't working PR is more than welcomed Extra attention is needed and removed need more info Further information is requested labels Nov 10, 2024
@HarelM
Copy link
Collaborator

HarelM commented Nov 10, 2024

Thanks @birkskyum for the video!

@HarelM HarelM added the showstopper Preventing from releasing a pre-release version as non-pre-release label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working globe Globe related issues PR is more than welcomed Extra attention is needed showstopper Preventing from releasing a pre-release version as non-pre-release
Projects
None yet
Development

No branches or pull requests

4 participants