WebGL matrix performance fix #5072
Open
+20
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to also have some hard perf numbers for this from a benchmark. I will see if there is a benchmark that can catch this and try to post some numbers tomorrow. |
|
Nice work and quick fix! |
HarelM
reviewed
Nov 19, 2024
| @@ -1197,7 +1197,7 @@ export class GlobeTransform implements ITransform { | |||
| const fallbackMatrixScaled = createMat4f64(); | |||
| mat4.scale(fallbackMatrixScaled, projectionData.fallbackMatrix, [EXTENT, EXTENT, 1]); | |||
|
|
|||
| projectionData.fallbackMatrix = fallbackMatrixScaled; | |||
| projectionData.fallbackMatrix = new Float32Array(fallbackMatrixScaled); | |||
There was a problem hiding this comment.
Does it make sense to create a 64f matrix and then save it as 32? It's it easier to create a 32 from the start or does it help precision and worth the conversion?
HarelM
reviewed
Nov 19, 2024
| @@ -416,7 +416,7 @@ export class MercatorTransform implements ITransform { | |||
| const tileMatrix = calculateTileMatrix(tileID, this.worldSize); | |||
| mat4.multiply(tileMatrix, aligned ? this._alignedProjMatrix : this._viewProjMatrix, tileMatrix); | |||
|
|
|||
| cache[posMatrixKey] = tileMatrix; | |||
| cache[posMatrixKey] = new Float32Array(tileMatrix); // Must be 32 bit floats, otherwise WebGL calls in Chrome get very slow. | |||
|
Added a small question around object creation... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5070 by passing float32 matrices to WebGL instead of float64. Note that the performance degradation only seemed to affect Chrome, not Firefox. Updates relevant unit & render tests.