Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update StrongName nuget package to same as non-signed one #73

Open
xumix opened this issue Mar 5, 2018 · 5 comments
Open

Please update StrongName nuget package to same as non-signed one #73

xumix opened this issue Mar 5, 2018 · 5 comments

Comments

@xumix
Copy link

xumix commented Mar 5, 2018

subj, cant use non-strongname one because of Signalr.redis

@gzpbx
Copy link

gzpbx commented Mar 28, 2018

+1, because Microsoft.AspNetCore.All => Microsoft.Extensions.Caching.Redis (2.0.1) => StackExchange.Redis.StrongName (1.2.4)

@sebastianbk
Copy link

The problem also occurs when using the Microsoft.AspNetCore.App package, which is now included by default in ASP.NET Core 2.1 projects.

A fix to this issue would be much appreciated.

@alecgorge
Copy link

I think this update is important because of the backwards-incompatible nature of the SE.Redis update I talked about in #78 (comment)

I'm on ASP.NET Core 2.1.x don't want to upgrade fully to SE.Redis 2.x yet, but I would like the fixes from the latest version of this package :)

In the meantime, I am using this as a workaround (add it as a child beneath the <Project> tag):

  <Target Name="ChangeAliasesOfStrongNameAssemblies" BeforeTargets="FindReferenceAssembliesForReferences;ResolveReferences">
    <ItemGroup>
      <ReferencePath Condition="'%(FileName)' == 'StackExchange.Redis.StrongName'">
        <Aliases>signed</Aliases>
      </ReferencePath>
    </ItemGroup>
  </Target>

This fixes the build errors, but causes any file that has using StackExchange.Redis to give this Intellisense error:

The type 'ConnectionMultiplexer' exists in both 'StackExchange.Redis.StrongName, Version=1.2.6.0, Culture=neutral, PublicKeyToken=c219ff1ca8c2ce46' and 'StackExchange.Redis, Version=1.2.6.0, Culture=neutral, PublicKeyToken=null'

If we are able to upgrade to the latest version of the strongname version of this package, the issue will go away completely.

@alecgorge
Copy link

Update: I was able to fix this by referencing Microsoft.AspNetCore.App instead of Microsoft.AspNetCore.All as suggested in StackExchange/StackExchange.Redis#697 (comment)

After I did that I had to add in a few dependencies I was missing that were in .All but not .App. After that, I was able to remove the .csproj fix I posted above because I wasn't using any of the ASP.NET Core features that depended on SE.Redis and now I only had the non-StrongName reference.

Anyone who uses SignalR, etc will still need that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants