From 5600695f0e8c75ddc52d1ce87dee736939962270 Mon Sep 17 00:00:00 2001 From: Marco Jakob Date: Wed, 13 Jun 2018 23:50:29 +0200 Subject: [PATCH] Cleanup for v1.0 --- CHANGELOG.md | 56 +++++++++---------- LICENSE | 2 +- example/index.html | 13 +++++ .../parent_offset}/example.css | 0 .../parent_offset}/example.dart | 0 example/parent_offset/index.html | 28 ++++++++++ .../scroll_offset}/example.css | 0 .../scroll_offset}/example.dart | 0 example/scroll_offset/index.html | 32 +++++++++++ pubspec.yaml | 8 +-- test/parent-offset/index.html | 23 -------- test/scroll-offset/index.html | 27 --------- tool/drone_io.sh | 27 --------- 13 files changed, 105 insertions(+), 111 deletions(-) rename {test/parent-offset => example/parent_offset}/example.css (100%) rename {test/parent-offset => example/parent_offset}/example.dart (100%) create mode 100644 example/parent_offset/index.html rename {test/scroll-offset => example/scroll_offset}/example.css (100%) rename {test/scroll-offset => example/scroll_offset}/example.dart (100%) create mode 100644 example/scroll_offset/index.html delete mode 100644 test/parent-offset/index.html delete mode 100644 test/scroll-offset/index.html delete mode 100755 tool/drone_io.sh diff --git a/CHANGELOG.md b/CHANGELOG.md index eb56f5e..0f2f46f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,94 +1,94 @@ # Changelog -## Version 1.0.0-alpha+1 (2018-05-05) +## Version 1.0.0 (2018-06-13) -* Migrate to Dart 2. -* Use pointer events for Edge, Firefox, Chrome. +- Migrate to Dart 2. +- Since Chrome 56 touch event listeners are [treated as passive by default](https://www.chromestatus.com/features/5093566007214080). This disables the possibility to call `preventDefault` on an element which we must do to tell the browser not to scroll while dragging. To fix this in Chrome we set the `touch-action` css property. With this Chrome will not scroll (`none`) or only scroll in one direction (`pan-y` or `pan-x`). ## Version 0.4.0 (2017-06-27) -* Fix strong mode errors (#20). +- Fix strong mode errors (#20). ## Version 0.3.6 (2017-06-06) -* Fix bug: Provide reasonable fallback for event target when mouse position exits viewport (#19). +- Fix bug: Provide reasonable fallback for event target when mouse position exits viewport (#19). ## Version 0.3.5 (2016-11-22) -* Handle the edge case where destroy is called while dragging an avatar (#17). +- Handle the edge case where destroy is called while dragging an avatar (#17). ## Version 0.3.4 (2016-10-19) -* Fix strong-mode type errors (#15). -* Remove Shadow DOM example and (dev)dependency on Polymer (was causing some confusion). +- Fix strong-mode type errors (#15). +- Remove Shadow DOM example and (dev)dependency on Polymer (was causing some confusion). ## Version 0.3.3 (2016-09-22) -* Allow a configurable clickSuppression distance (#13). We found that the click +- Allow a configurable clickSuppression distance (#13). We found that the click suppression was a little too aggressive for users with less mousing accuracy. They would attempt to click and trigger a small drag. Which then suppressed the click event and prevented the action they intended to complete. ## Version 0.3.2 (2016-07-26) -* Remove null-aware operator since drone.io uses an old version of Dart that doesn't support this yet. +- Remove null-aware operator since drone.io uses an old version of Dart that doesn't support this yet. ## Version 0.3.1 (2016-07-26) -* Support for programmatic drag abort (see issue #11). +- Support for programmatic drag abort (see issue #11). ## Version 0.3.0 (2015-04-18) -* BREAKING CHANGE: Refactoring the `AvatarHandler`. Only if you've +- BREAKING CHANGE: Refactoring the `AvatarHandler`. Only if you've implemented a custom `AvatarHandler` you might need to do some changes: - * `setPointerEventsNone` and `resetPointerEvents` were removed and don't + - `setPointerEventsNone` and `resetPointerEvents` were removed and don't need to be called any more. Pointer event styles are handled automatically. -* Fix `AvatarHandler` margin caching: The `AvatarHandler` only cached the +- Fix `AvatarHandler` margin caching: The `AvatarHandler` only cached the margins once for every `Draggable`. This caused problems when margins of elements in the same `Draggable` had different margins or the margins were changed. Now the margins are reset after every drag. ## Version 0.2.1 (2015-03-09) -* Fix #9: Using transformers in the main `pubspec.yaml` caused problems with +- Fix #9: Using transformers in the main `pubspec.yaml` caused problems with projects depending on the `dnd` package. ## Version 0.2.0 (2015-03-09) -* Fix #3: Shadow DOM is now supported. A `dnd-retarget` attribute must be added +- Fix #3: Shadow DOM is now supported. A `dnd-retarget` attribute must be added to all custom elements where events should be forwarded to the Shadow DOM children. -* Fix #7: Add a css class (`dnd-invalid` by default) to dropzones when a +- Fix #7: Add a css class (`dnd-invalid` by default) to dropzones when a not-accepted draggable is dragged over. ## Version 0.1.4 (2014-10-20) -* Add a sortable example. -* Change comments according to new Dart Style Guide rule +- Add a sortable example. +- Change comments according to new Dart Style Guide rule (`///` instead of `/** */`). -* Move event dispatching calls from EventManager to Draggable (refactoring). +- Move event dispatching calls from EventManager to Draggable (refactoring). ## Version 0.1.3 (2014-08-09) -* Fix #4: Problem when an ancestor of the dragged element was positioned +- Fix #4: Problem when an ancestor of the dragged element was positioned (relative, absolute, fixed). ## Version 0.1.2 (2014-07-22) -* Correcting small bug that occurred when setSelectionRange() was called on +- Correcting small bug that occurred when setSelectionRange() was called on an element that does not support it. -* Fix Pointer Event bug: Too many event listeners in move, end, cancel. -* Fix for Bug #1 - Not working in Windows 8.1 IE11 -* Adding a `cancelled` flag to `DraggableEvent` to indicate if a drag ended +- Fix Pointer Event bug: Too many event listeners in move, end, cancel. +- Fix for Bug #1 - Not working in Windows 8.1 IE11 +- Adding a `cancelled` flag to `DraggableEvent` to indicate if a drag ended because of a cancelling operation like `esc` key, etc. ## Version 0.1.1 (2014-07-21) -* Support for IE10 and IE11 touch screens through pointer events. -* Removed `disableTouch` and `disableMouse` options. The goal was to unify +- Support for IE10 and IE11 touch screens through pointer events. +- Removed `disableTouch` and `disableMouse` options. The goal was to unify touch and mouse dragging, so it should not be necessary to disable one or the other. ## Version 0.1.0 (2014-07-17) -* First version. +- First version. diff --git a/LICENSE b/LICENSE index 5c8b981..ef77dba 100644 --- a/LICENSE +++ b/LICENSE @@ -1,6 +1,6 @@ The MIT License (MIT) -Copyright (c) 2017 Marco Jakob +Copyright (c) 2018 Marco Jakob Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal diff --git a/example/index.html b/example/index.html index aa93d7f..9815cbe 100644 --- a/example/index.html +++ b/example/index.html @@ -54,6 +54,19 @@

Dart Drag and Drop Examples

Sortable + +

Just for Testing

+

+ The following examples are used for testing purposes: +

+ diff --git a/test/parent-offset/example.css b/example/parent_offset/example.css similarity index 100% rename from test/parent-offset/example.css rename to example/parent_offset/example.css diff --git a/test/parent-offset/example.dart b/example/parent_offset/example.dart similarity index 100% rename from test/parent-offset/example.dart rename to example/parent_offset/example.dart diff --git a/example/parent_offset/index.html b/example/parent_offset/index.html new file mode 100644 index 0000000..6203395 --- /dev/null +++ b/example/parent_offset/index.html @@ -0,0 +1,28 @@ + + + + + + + + + Dart Drag and Drop: Parent Offset Test + + + + + + +
+ Example Source on GitHub +
+

Drag me!

+
+
+ + + \ No newline at end of file diff --git a/test/scroll-offset/example.css b/example/scroll_offset/example.css similarity index 100% rename from test/scroll-offset/example.css rename to example/scroll_offset/example.css diff --git a/test/scroll-offset/example.dart b/example/scroll_offset/example.dart similarity index 100% rename from test/scroll-offset/example.dart rename to example/scroll_offset/example.dart diff --git a/example/scroll_offset/index.html b/example/scroll_offset/index.html new file mode 100644 index 0000000..79032b4 --- /dev/null +++ b/example/scroll_offset/index.html @@ -0,0 +1,32 @@ + + + + + + + + + Dart Drag and Drop: Scroll Offset Test + + + + + + +
+ Example Source on GitHub +
+

Drag me!

+
+ +
+ Scroll down and drag! +
+
+ + + \ No newline at end of file diff --git a/pubspec.yaml b/pubspec.yaml index e1dd931..74ea17e 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,12 +1,10 @@ name: dnd -version: 1.0.0-alpha+1 +version: 1.0.0 author: Marco Jakob description: Drag and Drop for Dart web apps with mouse and touch support. homepage: http://code.makery.ch/library/dart-drag-and-drop/ -documentation: https://www.dartdocs.org/documentation/dnd/latest/ environment: sdk: '>=2.0.0-dev.46.0 <2.0.0' - dev_dependencies: - build_runner: ^0.8.7 - build_web_compilers: ^0.3.7 \ No newline at end of file + build_runner: ^0.8.9 + build_web_compilers: ^0.4.0 \ No newline at end of file diff --git a/test/parent-offset/index.html b/test/parent-offset/index.html deleted file mode 100644 index 4a7f68c..0000000 --- a/test/parent-offset/index.html +++ /dev/null @@ -1,23 +0,0 @@ - - - - - - - -Dart Drag and Drop: Parent Offset Test - - - - - -
-
-

Drag me!

-
-
- - - - - diff --git a/test/scroll-offset/index.html b/test/scroll-offset/index.html deleted file mode 100644 index a958aeb..0000000 --- a/test/scroll-offset/index.html +++ /dev/null @@ -1,27 +0,0 @@ - - - - - - - -Dart Drag and Drop: Scroll Offset Test - - - - - -
-
-

Drag me!

-
- -
- Scroll down and drag! -
-
- - - - - diff --git a/tool/drone_io.sh b/tool/drone_io.sh deleted file mode 100755 index 471b19c..0000000 --- a/tool/drone_io.sh +++ /dev/null @@ -1,27 +0,0 @@ -# ----------------------------------- -# Script that builds Dart app and pushes it to gh-pages. -# -# Set following variables: -# ----------------------------------- -build_folder='example' -github_repo='git@github.com:marcojakob/dart-dnd.git' - -# ----------------------------------- -# Build. -# ----------------------------------- -pub install -pub build ${build_folder} - -# ----------------------------------- -# Configure git in build subfolder -# ----------------------------------- - -cd build/${build_folder} -git init -git add . - -# ----------------------------------- -# Deploy to github pages. -# ----------------------------------- -git commit -m 'deploy commit from drone' -git push -f ${github_repo} master:gh-pages \ No newline at end of file