Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger Plugin 🤓 #24

Open
Sherlouk opened this issue Mar 9, 2021 · 1 comment
Open

Danger Plugin 🤓 #24

Sherlouk opened this issue Mar 9, 2021 · 1 comment
Assignees

Comments

@Sherlouk
Copy link

Sherlouk commented Mar 9, 2021

Okay, so a bit of a far out there idea... and far from a priority!

But it could be really interesting to see a danger-swift-package-info plugin which builds on this executable.

https://github.com/danger/danger-plugin-template
https://danger.systems/guides/creating_your_first_plugin.html

I would expect it to detect all packages in the repository, and calculate the size diff for any package which has changed. It would then formulate a message or warning depending on how much the binary has increased by.

Warning: Binary size for "ContentModels" package has increased by 14% to 65.3 MB

Thresholds could be customisable!

image

@marinofelipe
Copy link
Owner

marinofelipe commented Mar 9, 2021

Another very interesting idea, @Sherlouk 👍 . I agree a ⚠️ Danger plugin would be very nice and would bring value for a lot of folks/companies out there that have danger integrated to their CI pipeline, I also see us using it @getyourguide in the future.

This would be my next priority after #3 and #15, and in the meantime I think we can discuss some draft ideas on how the plugin API and features would look like.

@marinofelipe marinofelipe self-assigned this Feb 4, 2024
@marinofelipe marinofelipe moved this to Todo in Open tasks Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants