Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per player logic #15

Open
mariusor opened this issue Nov 30, 2017 · 6 comments
Open

Per player logic #15

mariusor opened this issue Nov 30, 2017 · 6 comments
Milestone

Comments

@mariusor
Copy link
Owner

mariusor commented Nov 30, 2017

Since the MPRIS signals and metadata exposed differs on most of the media-players, I should implement some way of having a single point of verification for this information.

Then for each player I could implement this logic differently.

Current observed issues are:

Spotify

  • Doesn't populate correctly the track position property (neither volume, but that's less important for my use case). See ticket.

  • Triggers two signals with the exact same data when the track changes.

Audacious

  • Triggers an properties changed signal every time the track position advances. This leads to very high CPU usage because the scrobbler handles every signal.(This might not be that big of a problem) I don't know if there's a way to filter them.
@mariusor mariusor added this to the v1.0.0 milestone May 13, 2018
@Bergiu
Copy link

Bergiu commented Nov 13, 2018

MPV doesn't work too.

@mariusor
Copy link
Owner Author

mariusor commented Nov 13, 2018

Well, mpv doesn't expose the MPRIS interface, more so it doesn't seem to implement any DBUS functionality.

Unfortunatelly I can't do anything about that. You can open a ticket with mpv, but I doubt that they are interested if they didn't add it until now.

@Bergiu
Copy link

Bergiu commented Nov 14, 2018

I've forgot to say, that I'm using this mpv plugin:
https://github.com/hoyon/mpv-mpris

With that it is possible to get information and controll the player over mpris with playerctl.

mpris-scrobbler log on vlc:
https://hastebin.com/diwujagodo.php

playerctl output on vlc:
https://hastebin.com/nuzufolelu.rb

mpris-scrobbler log on mpv with mpv-mpris:
https://hastebin.com/qerinomivo.rb

playerctl output on mpv with mpv-mpris:
https://hastebin.com/enifugonib.rb

@mariusor
Copy link
Owner Author

I see.

From your debug log it seems that mpris-scrobbler can't load the track title when using mpv-mpris. I'll try to find the song to reproduce your issue.

I'll ping you if I find a solution.

@Bergiu
Copy link

Bergiu commented Nov 19, 2018

It works. Thanks for you work.

@mariusor
Copy link
Owner Author

No problem, I'm glad that someone is actually using the scrobbler besides me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants