Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the salami namespace definitions #133

Closed
bmcfee opened this issue Sep 20, 2016 · 1 comment
Closed

Error in the salami namespace definitions #133

bmcfee opened this issue Sep 20, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@bmcfee
Copy link
Contributor

bmcfee commented Sep 20, 2016

In preparing for #128 , I noticed that the SALAMI-upper and lower regexps match [A-Z]+'*, which is intended to capture things like AAA''', but could erroneously match ABC''.

The proper way to do this is to use a backreference, eg, ([A-Z])\1*.

It's not clear that jsonschema supports PCRE backreferences though, so we might have to run this out by hand: `A+|B+|C+|...|Z+'.

@bmcfee bmcfee added the bug label Sep 20, 2016
@bmcfee bmcfee added this to the 0.2.2 milestone Sep 20, 2016
@bmcfee bmcfee self-assigned this Sep 20, 2016
@bmcfee
Copy link
Contributor Author

bmcfee commented Sep 20, 2016

Upon closer inspection, it appears that jsonschema uses the ecma-262 regex dialect, which does support back-references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant