Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Pages gem to fix issue with Ruby versions >= 3.3.0 #112

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

zackkrida
Copy link
Contributor

The previous version of the GitHub pages gem, v227, had an issue with the latest version of Ruby (any greater than 3.3.x, or any version using ruby/logger 1.4.3 or greater. See the issue here: jekyll/jekyll#9392). Updating this gem to v232 updates Jekyll to > 3.9.4, where the logger compatibility issue is fixed.

This is a more dependable solution than some alternatives:

  • Downgrade my personal Ruby version and enforce a specific version < 3.3.0
  • Updating the jekyll gem directly with bundle update jekyll

Testing instructions

  1. Checkout this PR and bundle install.
  2. Run the site locally with bundle exec jekyll serve --port 4000 --livereload and confirm it matches the production site
  3. Bonus, optional: Checkout main, update your Ruby version to something > 3.3.0 (Perhaps with rvm install ruby --latest or rbenv install 3.3.1) and verify that the site fails to run locally with an error message mentioning the @level_override[Fiber.current] configuration.

The previous version of the GitHub pages gem, v227, had an issue with the latest version of Ruby (any greater than 3.3.x, or any version using ruby/logger 1.4.3 or greater. See the issue here: jekyll/jekyll#9392). Updating this gem to v232 updates Jekyll to > 3.9.4, where the logger compatibility issue is fixed.
@zackkrida
Copy link
Contributor Author

I'm going to go ahead and merge this. @kgodey let me know if for changes like this in the future I should prioritize getting a review and who might be a good reviewer for the website.

@zackkrida zackkrida merged commit 1c0a3d2 into master Dec 17, 2024
1 check passed
@zackkrida zackkrida deleted the update-gh-pages-gem-version branch December 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant