Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for plaintext leaking in logs #136

Open
kegsay opened this issue Sep 21, 2024 · 2 comments
Open

Add tests for plaintext leaking in logs #136

kegsay opened this issue Sep 21, 2024 · 2 comments

Comments

@kegsay
Copy link
Member

kegsay commented Sep 21, 2024

It's very important we don't leak plaintext messages in logs. We should be able to test that stdout/log files do not contain certain sentinel strings. This may require some kind "please enable verbose logging" option in the API.

@poljar
Copy link
Contributor

poljar commented Sep 21, 2024

If you mean that you need such an API in the bindings, you should be able to do this already: https://github.com/matrix-org/matrix-rust-sdk/blob/2a03de3bd5ffd57dc63328964cb430be786d426e/bindings/matrix-sdk-ffi/src/platform.rs#L246-L252.

@kegsay
Copy link
Member Author

kegsay commented Sep 24, 2024

I mean the complement-crypto API - most SDKs have the ability to enable trace logging somehow. I use the rust one already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants