Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device lists contains user ids from unencrypted rooms #2668

Open
fred84 opened this issue Aug 23, 2022 · 1 comment
Open

Device lists contains user ids from unencrypted rooms #2668

fred84 opened this issue Aug 23, 2022 · 1 comment
Labels
C-Keyserver F-E2EE T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Performance Issue/PR around something that is slow or taking lots of memory

Comments

@fred84
Copy link

fred84 commented Aug 23, 2022

According to the docs, changed and left in device_lists should contain user ids from encrypted chats :

List of users who have updated their device identity or cross-signing keys, or who now share an encrypted room with the client since the previous sync response.

However, both lists are populated without taking into account if a room is encypted or not. Sytest 06-device-list.pl also ignore "encrypted" property of a room.

Who is right: current implementation or docs?

P.S. Related sytest issue: matrix-org/sytest#1280
@kegsay kegsay added X-Needs-Info This issue is blocked awaiting information from the reporter and removed needs investigation labels Dec 5, 2022
@kegsay
Copy link
Member

kegsay commented Dec 6, 2022

Docs. Unencrypted rooms have no need to know device lists.

@kegsay kegsay added T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Performance Issue/PR around something that is slow or taking lots of memory F-E2EE and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Keyserver F-E2EE T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Performance Issue/PR around something that is slow or taking lots of memory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fred84 @neilalexander @kegsay