New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential Precision Loss When Using Normal Data in PNG Format #55

Open

wzy-99 opened this issue Jul 20, 2024 · 1 comment

wzy-99 commented Jul 20, 2024

I would like to bring attention to a potential issue regarding the precision of normal data in the get_normal_filepaths method.

dn-splatter/dn_splatter/data/coolermap_dataparser.py

Line 99 in aa754d8

return natsorted(glob.glob(f"{self.normal_save_dir}/*.png"))

Currently, normal data is being stored in .png and .npy format. But this method only uses png, which may result in precision loss.

Owner

maturk commented Jul 20, 2024

That is an interesting point ... I have not considered this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment