Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable username format for webhook relays #155

Open
austinhuang0131 opened this issue Jul 29, 2024 · 2 comments
Open

Configurable username format for webhook relays #155

austinhuang0131 opened this issue Jul 29, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@austinhuang0131
Copy link

Originally posted at https://geekdom.social/@bigolifacks/112859769835968061 (not me); the concerning code is

discord/portal.go

Lines 1436 to 1441 in 035f2a4

func (portal *Portal) getRelayUserMeta(sender *User) (name, avatarURL string) {
member := portal.bridge.StateStore.GetMember(portal.MXID, sender.MXID)
name = member.Displayname
if name == "" {
name = sender.MXID.String()
}

so eg. allows the bridge to always include MXID in the webhook display name.

@austinhuang0131 austinhuang0131 added the enhancement New feature or request label Jul 29, 2024
@tulir
Copy link
Member

tulir commented Aug 2, 2024

Making it configurable doesn't really solve anything. I'll probably include proper disambiguation in megabridge, but I couldn't find any Go libraries for UTS #39 confusable detection, so will need to write one first

@Raymo111
Copy link

Raymo111 commented Dec 2, 2024

@tulir Making it configurable solves the problem of people not knowing where the webhook is bridging from (enables appending something like | from CC Chat. I think having it would be a good feature even without the megabridge disambig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants