Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top sites more important than open tabs #271

Closed
stalkerg opened this issue Sep 4, 2018 · 2 comments
Closed

Top sites more important than open tabs #271

stalkerg opened this issue Sep 4, 2018 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@stalkerg
Copy link

stalkerg commented Sep 4, 2018

Will be good to configure the order of elements on the page.
I have information about all tabs in tabs anyway. :)

@maxmilton maxmilton added the enhancement New feature or request label Sep 4, 2018
@maxmilton maxmilton added this to the v1.0.0 milestone Sep 4, 2018
@maxmilton
Copy link
Owner

It's a good point that different users will value each results list differently. Personally I prefer tabs at the top but I've asked around and some people also prefer top sites first.

I'll have a go at making this a setting, perhaps a drag and drop UI for the 4 different results lists. It will be a challenge making this work with the kind of speed I want from the page load because getting the user settings from storage is async and effects the code execution order... but it's something I need to address for loading the theme too.

@maxmilton
Copy link
Owner

In the setting UI it's now possible to reorder or even remove sections entirely. It's been a thing for a while even in the current public Chrome Web Store version so I'm closing this issue.

To be honest the setting UI need visual improvement but it does work. I've listed this as a blocker task in preparation for the next public release in #1118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants