Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicons not updating when the site is not in Chrome's favicon cache #277

Open
maxmilton opened this issue Sep 4, 2018 · 0 comments
Open
Labels
bug Something isn't working
Milestone

Comments

@maxmilton
Copy link
Owner

maxmilton commented Sep 4, 2018

Another issue arising from PR #273, in order to get the best possible performance, favicons are loaded directly from the Chrome favicon cache (chrome://favicon/). This is amazing for performance because there's no remote network requests slowing down page rendering.

The issue arises in that when you open a website for the first time and its favicon is not in the cache, it will never change from the default favicon, even after the chrome.tabs.onUpdated event. Apparently it can take a moment for the favicon to be added to the cache but its well after the tab update event has fired.

There are some existing Chrome bugs which could be related to this but we might still be able to implement a workaround using a combination of chrome://favicon/ and changeInfo.favIconUrl in the meantime.

Related:

@maxmilton maxmilton added the bug Something isn't working label Sep 4, 2018
@maxmilton maxmilton added this to the v1.0.0 milestone Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant