Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I think this is the wrong syntax, which we don't notice as long as everything works. #57

Open
jedimatt42 opened this issue Aug 24, 2024 · 1 comment
Open

I think this is the wrong syntax, which we don't notice as long as everything works. #57

jedimatt42 opened this issue Aug 24, 2024 · 1 comment

Comments

@jedimatt42
Copy link
Contributor

tms9900-gcc/install.sh

Line 25 in ecf4b31

if [ ! $? == 0 ] ; then

I believe for numeric comparison the syntax needs to be different...

  if [ $? -ne 0 ] ; then
@mburkley
Copy link
Owner

Yeah I think that script needs a bit of work. I noticed also the find latest reg exp doesn't work correctly when I moved to 2.x. I'll take a look sometime at refactoring the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jedimatt42 @mburkley