New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Average the loss? #5

Open

heli-sudoo opened this issue Jan 4, 2022 · 0 comments

heli-sudoo commented Jan 4, 2022

berkeley-deep-RL-pytorch-solutions/hw2/cs285/policies/MLP_policy.py

Line 115 in 47da611

loss = torch.sum((-logprob_pi * torch.Tensor(adv_n).to(self.device)))

Shall the loss be averaged by N? I apologize if I am wrong. Do not have much experience with RL. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment