Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear media query placement example #280

Open
j9t opened this issue Jul 30, 2022 · 0 comments
Open

Unclear media query placement example #280

j9t opened this issue Jul 30, 2022 · 0 comments

Comments

@j9t
Copy link
Contributor

j9t commented Jul 30, 2022

The media query placement example is unclear (and can be seen as contradicting the rule).

While the rule suggests not to bundle media queries “at the end of the document,” the example can be understood as doing exactly that, as the media query block comes at the end of the sample, with nothing seemingly following it.

Something like adding more rules, a comment, or just an ellipsis could make this clearer:

.element { … }
.element-avatar { … }
.element-selected { … }

@media (min-width: 480px) {
  .element { … }
  .element-avatar { … }
  .element-selected { … }
}

.another-element { … }
.and-another-element { … }
.and-yet-another-element { … }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant