Parsing error: Expected value to be truthy

[tmpduarte]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

2.0.2

Link to runnable example

https://github.com/tmpduarte/eslint-mdx-visit-issue/tree/issue/expected-value-to-be-truthy

Steps to reproduce

Minimal Example

Minimal repository producing this issue with a fresh Vite / TypeScript / React / Storybook / MUI project.

Steps taken
Forked this repository, added the setup needed to use MUI and updated the eslint-mdx to the latest version.

kudos to @sudosilico for the setup 🙏

Expected behavior

.mdx file should should be linted without parsing errors.

Actual behavior

$ yarn lint
yarn run v1.22.15
$ eslint --ext .ts,.tsx,.js,.jsx,.mdx src

/workspaces/eslint-mdx-visit-issue/src/stories/Button.stories.mdx
  0:0  error  Parsing error: Expected value to be truthy

✖ 1 problem (1 error, 0 warnings)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Runtime

Node v16

Package manager

yarn v1

OS

macOS

Build and bundle tools

Vite

[JounQin]

Thanks for reproduction, I'll check later.

[JounQin]

See tmpduarte/eslint-mdx-visit-issue#1

1. You're using eslint-plugin-mdx@2.0.0, but you tricked to say the affected version was 2.0.2
2. See also build(deps-dev): bump eslint-plugin-mdx from 2.0.1 to 2.0.2 webpack/webpack.js.org#6297 (comment) and chore: ensure to run yarn-deduplicate with fewer strategy webpack/webpack.js.org#6301

[JounQin]

@wooorm Do you have any idea that how can we ensure same acorn and acorn-jsx versions between eslint-mdx vs micromark-extension-mdxjs? Will an optional peer dependency declaration of micromark-extension-mdxjs work?

Because acorn.tokTypes and acornJsx.tokTypes are different between versions.

[wooorm]

micromark-extension-mdxjs takes acorn as an instance: https://github.com/micromark/micromark-extension-mdxjs#optionsacorn. You can pass an instance of the version you use.

[JounQin]

@wooorm If I didn't remember wrong, micromark-extension-mdxjs is referenced from remark-mdx, but remark-mdx doesn't provide an acorn/acornJsx options.

[wooorm]

And it accepts options.
You can pass the acorn version you want.

https://github.com/mdx-js/mdx/blob/main/packages/remark-mdx/index.js
https://github.com/micromark/micromark-extension-mdxjs/blob/main/index.js

[JounQin]

OK then, I think I can give it a try tonight. Thanks!

[tmpduarte]

@JounQin thank you very much for taking a look a this 🙏

There might have been a confusion.
The link I posted on the description is for a specific branch that has the version 2.0.2 as well as the MUI button in the storybook story, and that's where the problem happens.

The main branch, used to replicate the problem actually has not problem at all. Sorry for the confusion 🙏

[TxHawks]

I'm also getting this with version 2.0.3, node v16.13.2 and pnpm v7.9.5

[JounQin]

I'm also getting this with version 2.0.3, node v16.13.2 and pnpm v7.9.5

Please provide a minimal but runnable reproduction in a new issue then.

[jvdl]

I've opened up #429 as a continuation of this issue with a repro / failing test.