Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the canny_edge_detection input stream from ImAxis<24> to ap_axiu<24,1,1,1> #2

Open
3togo opened this issue May 25, 2019 · 2 comments

Comments

@3togo
Copy link

3togo commented May 25, 2019

I want to modify your code so that it could take hls::stream<ap_axiu<24,1,1,1>>& instead of hls::stream<ImAxis<24>>&

i.e from
void canny_edge_detection(stream<ImAxis<24>>& axis_in, stream<ImAxis<24> >& axis_out,
uint8_t& hist_hthr, uint8_t& hist_lthr)
to
void canny_edge_detection(stream<ap_axiu<24,1,1,1>>& axis_in, stream<ap_axiu<24,1,1,1>>& axis_out,
uint8_t& hist_hthr, uint8_t& hist_lthr)

But, vivado_hls keeps complaining there is left over data, can you advise me how to do it?
Many thanks

@3togo
Copy link
Author

3togo commented May 25, 2019

not working
HlsImProc.hpp.txt

@medalotte
Copy link
Owner

Hi @3togo

Thank you for your comment.
I'm using ImAxis<24> which have only 5 signals (data, valid, ready, user, and last) instead of ap_axiu<24,1,1,1> because of due to specification of AXI VDMA.

I checked working my code using Vivado HLS 2018.2 now, however, I think it is no problem as far as I saw the synthesis log.

Could you show me such as error log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants