Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: medusa/ui breaks with tailwindcss v4 #11040

Open
pnodet opened this issue Jan 18, 2025 · 0 comments · May be fixed by #11041
Open

[Bug]: medusa/ui breaks with tailwindcss v4 #11040

pnodet opened this issue Jan 18, 2025 · 0 comments · May be fixed by #11041
Labels
status: needs triaging version: 2.0

Comments

@pnodet
Copy link

pnodet commented Jan 18, 2025 •
edited
Loading

env

❯ npx envinfo --system --binaries --browsers --npmPackages "{@medusajs/*,tailwindcss,@tailwindcss/*,postcss-mixins}"

  System:
    OS: macOS 15.2
    CPU: (14) arm64 Apple M4 Pro
    Memory: 68.72 MB / 24.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.13.0 - ~/.local/state/fnm_multishells/8096_1736968971589/bin/node
    npm: 10.9.2 - ~/.local/state/fnm_multishells/8096_1736968971589/bin/npm
    pnpm: 9.15.4 - ~/.local/state/fnm_multishells/8096_1736968971589/bin/pnpm
    bun: 1.1.43 - /opt/homebrew/bin/bun
  Browsers:
    Chrome: 132.0.6834.84
    Safari: 18.2
  npmPackages:
    @medusajs/ui: 4.0.3 => 4.0.3
    @medusajs/ui-preset: 2.3.0 => 2.3.0
    @tailwindcss/postcss: 4.0.0-beta.8 => 4.0.0-beta.8
    tailwindcss: 4.0.0-beta.8 => 4.0.0-beta.8

Node.js version

v22.13.0

What happended?

tailwindcss v4 is currently in beta and contains some changes. Apart from some behavior differences medusa/ui could work with it if configured correctly.

However among the changes made the tailwindcss package does not include the defaultTheme export which breaks since medusa/ui imports it.
pnodet added a commit to pnodet/medusa that referenced this issue Jan 18, 2025
@pnodet
refactor(ui-preset): replace defaultTheme import
40c7320 
Removing the import allows future compatibilty with tailwind v4 where it
won't be exported anymore. Fix medusajs#11040
@pnodet pnodet linked a pull request Jan 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triaging version: 2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(ui-preset): replace defaultTheme import pnodet/medusa
1 participant
@pnodet