-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Each child in a list should have a unique "key" prop. #55
Comments
@CaroFG are you sure it does not come from react-isntantsearch, so on the algolia side? |
A user said it appeared when he moved from Algolia to Meilisearch, see Discord. As I told the user, I guess Algolia uses by default the objectID they generate for each document, but since we don't use an objectID we should probably provide an example that does not trigger a warning. |
Thanks for the context! |
Hello, may I work on this issue? |
Go ahead @replyre! |
Hi @replyre. any news?) |
Hello @voronovmaksim |
hey @voronovmaksim, I looked through it but wasn't able to find the root of the issue. Sorry, I forgot to mention it earlier. I will look at it again if you wish on Saturday, as I'm busy right now. |
Description
Description of what the bug is about.
Using the provided example we get a react warning:
Expected behavior
What you expected to happen.
The example should provide a unique key to each hit, so that the warning is not triggered.
Current behavior
What happened.
The code sandbox hit component has a key property, but it does not remove the warning:
Screenshots or Logs
If applicable, add screenshots or logs to help explain your problem.
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: