Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make name dict non-nullable and remove loadNames function #2153

Open
melink14 opened this issue Aug 18, 2024 · 0 comments
Open

Make name dict non-nullable and remove loadNames function #2153

melink14 opened this issue Aug 18, 2024 · 0 comments
Labels
Code health Issues which if fixed would improve the health of the project (as opposed to new features/bugs) easy good first issue

Comments

@melink14
Copy link
Owner

Currently loadNames is the only caller of fileRead which uses the deprecated XMLHttpRequest.

loadNames is called before doing name lookups but always returns instantly because we always initialize names dictionary at startup.

Instead, we should just make names dictionary non nullable and remove loadNames and the fileRead function it calls, thus getting rid of XMLHttpRequest
@melink14 melink14 added Code health Issues which if fixed would improve the health of the project (as opposed to new features/bugs) good first issue easy labels Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code health Issues which if fixed would improve the health of the project (as opposed to new features/bugs) easy good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@melink14