Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formalize and document PR review process and requirements for merge #301

Open
cjohnhanson opened this issue Jul 19, 2022 · 1 comment
Open

Formalize and document PR review process and requirements for merge #301

cjohnhanson opened this issue Jul 19, 2022 · 1 comment
Labels
Documentation Improvements or additions to documentation

Comments

@cjohnhanson
Copy link
Contributor

This should include:

  • Detailed team-specific processes in the PR process docs for the engineering team
  • Contributor processes and requirements should be documented in the contributor guide
  • A basic PR template should be added to meltano/meltano with a checklist for merge requirements and links to the relevant documentation
@cjohnhanson cjohnhanson added the Documentation Improvements or additions to documentation label Jul 19, 2022
@cjohnhanson cjohnhanson self-assigned this Jul 19, 2022
@WillDaSilva
Copy link
Member

meltano/meltano#6407 (comment)

A note about keeping the PR description up-to-date should be added to the handbook & template.

@cjohnhanson cjohnhanson removed their assignment Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjohnhanson @WillDaSilva