For Terraform/IAC MRs: create style guide, code standards, best practices, and definition of done

[MeltyBot]

Migrated from GitLab: https://gitlab.com/meltano/handbook/-/issues/68

Originally created by @aaronsteers on 2022-03-02 21:58:21

---

First raised here: https://gitlab.com/meltano/squared/-/merge_requests/70#note_860678737

For terraform resources, let's create a set of code standards:

guidelines such as:

• Code matches terraform fmt auto-format output.
• What docs are expected - inline and in markdown docs - for definition of done?
• Should we have a top-of-file "docstring" for each .tf file?
• camel_case vs kebab-case for resource and variable names? I personally favor camel_case but anyway the project currently uses both.
• Disallow using our own aws account IDs in .tf files. (Replaced by data refs, relative refs, or input vars.)
• ...

[MeltyBot]

View 10 previous comments from the original issue on GitLab