Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to support Jsonnet #65

Open
mhemken-nyt opened this issue Oct 5, 2021 · 6 comments
Open

Plans to support Jsonnet #65

mhemken-nyt opened this issue Oct 5, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@mhemken-nyt
Copy link

Hello, Jsonnet is a much more flexible configuration language than yaml. My use case is one where a .drone.yml file would repeat code dozens of times. Jsonnet allows me to stay DRY. But this plugin doesn't work if I use a .drone.jsonnet file directly.

Are there plans to support Jsonnet with this plugin?

@jimsheldon jimsheldon added the enhancement New feature or request label Oct 11, 2021
@jimsheldon
Copy link

Just to make sure I understand, you have set DRONE_JSONNET_ENABLED=true for your drone server, which allows drone to read .drone.jsonnet files in your repo rather than .drone.yml?

This doesn't directly solve your problem, but I believe it should be possible to convert your .drone.jsonnet file to a .drone.yml with the drone jsonnet command, which would be compatible with this plugin.

Our team will discuss potentially adding this feature and reply back.

@jimsheldon
Copy link

I have discussed this with my team. We don't have any immediate plans to support this feature, but we would welcome a pull request to add it.

For anyone else who would like to see this, please add a thumbs up to the initial post so we can measure interest.

@raphendyr
Copy link

See harness/harness#2994

@hikerspath hikerspath changed the title Plans to support Jsonnet? Plans to support Jsonnet Aug 9, 2022
@hikerspath
Copy link
Member

As @raphendyr mentions above, this is a long-running issue and waiting on the support of multiple convert plugins.

@hikerspath
Copy link
Member

FWIW, should be no changes needed to existing footprint drone is able to execute multiple convert plugins.

@wez
Copy link

wez commented Sep 18, 2023

FWIW, setting DRONE_CONVERT_MULTI=true and DRONE_STARLARK_ENABLED=true on the drone server allows mixing both starlark and this conversion plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants