You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rest API's of Stash are paginated and have a default page size of 25. As a result when the plugin fetches the diff via go-scm it only picks up the first 25 paths that were affected in the PR/commit. Diffs with greater than 25 paths affected isn't uncommon for a monorepo. stash.go#GetStashFilesChanged takes in a pagination parameter but plugin doesn't have a way to set the size option.
Add an environment variable to set the page size to a higher value.
Applicable pipelines must be evaluated based on the entire changeset and not just the first page (Bitbucket sets the limit to 1000 when making api requests for its web gui)
The text was updated successfully, but these errors were encountered:
madappa-sharath
changed the title
Allow Bitbucket/Stash users to specify Size parameter of scm.ListOptions, by default only picks up first 25 paths in diff
Allow Stash users to specify Size parameter of scm.ListOptions, by default only picks up first 25 paths in diff
Aug 11, 2022
madappa-sharath
pushed a commit
to madappa-sharath/drone-convert-pathschanged
that referenced
this issue
Aug 11, 2022
Rest API's of Stash are paginated and have a default page size of 25. As a result when the plugin fetches the diff via go-scm it only picks up the first 25 paths that were affected in the PR/commit. Diffs with greater than 25 paths affected isn't uncommon for a monorepo. stash.go#GetStashFilesChanged takes in a pagination parameter but plugin doesn't have a way to set the size option.
Add an environment variable to set the page size to a higher value.
References:
https://docs.atlassian.com/bitbucket-server/rest/4.0.0/bitbucket-rest.html#paging-params
https://github.com/drone/go-scm/blob/3edbe5560fdc172e093e6214196ee37ce516152d/scm/driver/stash/git.go#L114
drone-convert-pathschanged/plugin/plugin.go
Line 169 in 77a9eeb
Expected behavior
Applicable pipelines must be evaluated based on the entire changeset and not just the first page (Bitbucket sets the limit to 1000 when making api requests for its web gui)
The text was updated successfully, but these errors were encountered: