Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not post an apply comment to the last commit #33

Open
shiwano opened this issue Feb 17, 2019 · 1 comment
Open

Can not post an apply comment to the last commit #33

shiwano opened this issue Feb 17, 2019 · 1 comment

Comments

@shiwano
Copy link

shiwano commented Feb 17, 2019

Hi,

I'd like to use tfnotify for a GitHub repository whose merging option is squash-and-merge, but tfnotify does not post an apply comment to the last commit (it always posts to one before the last commit).

https://github.com/mercari/tfnotify/blob/master/notifier/github/commits.go#L46

I think this code is a cause. The squash-and-merge commit history does not include the merge commit, so lastOne method does not return the correct one. Is it make sense?

It's implicit behavior, so I would like to configure it in tfnotify.yml if possible.

Thanks.

@shiwano shiwano changed the title Can not post apply comment to the last commit when GitHub's merging option is squash-and-merge Can not post an apply comment to the last commit Mar 1, 2019
@Fumipo-Theta
Copy link

I have encountered the same problem with squash-and-merge on a GitHub repository, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants