You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like to use tfnotify for a GitHub repository whose merging option is squash-and-merge, but tfnotify does not post an apply comment to the last commit (it always posts to one before the last commit).
I think this code is a cause. The squash-and-merge commit history does not include the merge commit, so lastOne method does not return the correct one. Is it make sense?
It's implicit behavior, so I would like to configure it in tfnotify.yml if possible.
Thanks.
The text was updated successfully, but these errors were encountered:
shiwano
changed the title
Can not post apply comment to the last commit when GitHub's merging option is squash-and-merge
Can not post an apply comment to the last commit
Mar 1, 2019
Hi,
I'd like to use tfnotify for a GitHub repository whose merging option is squash-and-merge, but tfnotify does not post an apply comment to the last commit (it always posts to one before the last commit).
https://github.com/mercari/tfnotify/blob/master/notifier/github/commits.go#L46
I think this code is a cause. The squash-and-merge commit history does not include the merge commit, so
lastOne
method does not return the correct one. Is it make sense?It's implicit behavior, so I would like to configure it in
tfnotify.yml
if possible.Thanks.
The text was updated successfully, but these errors were encountered: