Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add ".local" addresses to isPrivateIpAddress() #5306

Open
pdxlocations opened this issue Nov 10, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@pdxlocations
Copy link
Member

pdxlocations commented Nov 10, 2024

Platform

Cross-Platform

Description

isPrivateIpAddress checks for local IP address octets but does not include a check for .local addresses.

@pdxlocations pdxlocations added the enhancement New feature or request label Nov 10, 2024
@fifieldt
Copy link
Contributor

@fifieldt
Copy link
Contributor

Just checking, @pdxlocations - do you use this domain for mqtt or know of people that do, or is this more of a request to make the function "complete" ?

@pdxlocations
Copy link
Member Author

I had been using, for example: raspberrypi.local to connect to my broker. I've since changed to using the IP address to take advantage of the iPrivateIpAddress function.

The feature request is not dire but as you said to make the function "complete". If we want to honor "All" local addresses adding .local may save a user some frustration. Alternatively, or in addition to, I'd be happy to write something up for the docs listing the allowable formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants