Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance in Environment Telemetry is not actually serialized into protobufs #5349

Open
ndoo opened this issue Nov 14, 2024 · 1 comment
Open

Comments

@ndoo
Copy link
Contributor

ndoo commented Nov 14, 2024

Hi @caveman99, I think despite the addition of ultrasonic distance sensing during #3678 , /src/serialization/MeshPacketSerializer.cpp and possibly the nRF version of this file would need the meshtastic_PortNum_TELEMETRY_APP section updated to actually put the distance out into transmitted protobufs.

@caveman99
Copy link
Member

The actual protobuf has the data field, like intended in the original PR, the files you mention just serialize into the JSON export format and only carry a subset of the available data. Looks like nobody needed that data point on the JSON yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants