From 6ed553048dde5126a2d788fa1b2100199e9e5681 Mon Sep 17 00:00:00 2001 From: Chris Truter Date: Wed, 2 Oct 2024 01:04:37 +0200 Subject: [PATCH] lil tweakz --- .../acceptance/bigquery__table_wildcard.analysis.edn | 2 +- .../acceptance/compound__cte_masking.analysis.edn | 7 ++++--- test/resources/acceptance/shadow__subselect.analysis.edn | 5 +---- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/test/resources/acceptance/bigquery__table_wildcard.analysis.edn b/test/resources/acceptance/bigquery__table_wildcard.analysis.edn index be65d81..f282e3f 100644 --- a/test/resources/acceptance/bigquery__table_wildcard.analysis.edn +++ b/test/resources/acceptance/bigquery__table_wildcard.analysis.edn @@ -3,7 +3,7 @@ :overrides {:basic-select - ;; do not allow wilcard selects + ;; do not allow wildcard selects {:tables :macaw.error/illegal-expression} ;; Just plain old whacky diff --git a/test/resources/acceptance/compound__cte_masking.analysis.edn b/test/resources/acceptance/compound__cte_masking.analysis.edn index 2ede091..7f1b126 100644 --- a/test/resources/acceptance/compound__cte_masking.analysis.edn +++ b/test/resources/acceptance/compound__cte_masking.analysis.edn @@ -4,6 +4,7 @@ ;; See https://github.com/metabase/metabase/issues/42586 :overrides - ;; TODO currently each table gets hidden by the other CTE - {:tables [] - :source-columns []}} + {:ast-walker-1 + ;; TODO currently each table gets hidden by the other CTE + {:tables [] + :source-columns []}}} diff --git a/test/resources/acceptance/shadow__subselect.analysis.edn b/test/resources/acceptance/shadow__subselect.analysis.edn index 32c13f3..02a0085 100644 --- a/test/resources/acceptance/shadow__subselect.analysis.edn +++ b/test/resources/acceptance/shadow__subselect.analysis.edn @@ -12,7 +12,4 @@ {:source-columns #{{:table "departments" :column "id"} {:table "departments" :column "name"} {:column "first_name"} - {:column "last_name"}} - - :basic-select - {:tables ::not-implemented}}} + {:column "last_name"}}}}