Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py imports numpy #18

Open
yannbouteiller opened this issue Sep 5, 2023 · 3 comments · May be fixed by #19
Open

setup.py imports numpy #18

yannbouteiller opened this issue Sep 5, 2023 · 3 comments · May be fixed by #19
Assignees
Labels
bug Something isn't working

Comments

@yannbouteiller
Copy link

yannbouteiller commented Sep 5, 2023

Hello,

numpy, which is not in the standard library, is currently imported in setup.py.

This breaks pip behavior when installing fastgrab (e.g., when numpy is not installed).

This hack would probably solve this.

@mherkazandjian mherkazandjian self-assigned this Jan 15, 2024
@mherkazandjian mherkazandjian added the bug Something isn't working label Jan 15, 2024
@mherkazandjian
Copy link
Owner

mherkazandjian commented Jan 15, 2024

Hi @yannbouteiller , thank you for reporting this. it looks like a simple quick fix. i will look into it.

@AndreaOrru
Copy link

I'm also experiencing this.

@Arcitec
Copy link

Arcitec commented May 29, 2024

Can confirm, this error happens when installing, both from git and from pypi. The setup.py is not properly written to tell Python that numpy is needed for the build.

@Arcitec Arcitec linked a pull request May 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants