Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

254 update import automation to be compatible with berkeley metadata and endpoints #258

Merged
merged 24 commits into from
Oct 8, 2024
Merged

254 update import automation to be compatible with berkeley metadata and endpoints #258

merged 24 commits into from
Oct 8, 2024
+100 −69

Conversation

aclum
Copy link
Contributor

@aclum aclum commented Oct 1, 2024 •
edited
Loading

This PR

  • updates code and tests for import automation for berkeley
  • adds TODO for tests for test_imports.py

@aclum aclum changed the title 254 update nmdc automationimport automation to be compatible with berkley metadata and endpoints 254 update nmdc automationimport automation to be compatible with berkeley metadata and endpoints Oct 1, 2024
@aclum aclum changed the title 254 update nmdc automationimport automation to be compatible with berkeley metadata and endpoints 254 update import automation to be compatible with berkeley metadata and endpoints Oct 1, 2024
@aclum aclum marked this pull request as ready for review October 1, 2024 21:11
@aclum aclum linked an issue Oct 1, 2024 that may be closed by this pull request
Update nmdc_automation.import_automation to be compatible with Berkley metadata and endpoints #254
Open
mbthornton-lbl
mbthornton-lbl requested changes Oct 8, 2024
View reviewed changes
nmdc_automation/import_automation/utils.py Outdated Show resolved Hide resolved
nmdc_automation/import_automation/utils.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/test_imports.py Outdated Show resolved Hide resolved
tests/test_imports.py Show resolved Hide resolved
aclum and others added 8 commits October 8, 2024 11:44
@aclum @mbthornton-lbl
Update nmdc_automation/import_automation/utils.py
a4bcf7f 
Co-authored-by: Michael Thornton <142261515+mbthornton-lbl@users.noreply.github.com>
@aclum @mbthornton-lbl
Update nmdc_automation/import_automation/utils.py
d83feb6 
Co-authored-by: Michael Thornton <142261515+mbthornton-lbl@users.noreply.github.com>
@aclum @mbthornton-lbl
Update tests/test_imports.py
f69534e 
Co-authored-by: Michael Thornton <142261515+mbthornton-lbl@users.noreply.github.com>
@aclum
Update utils.py
13e8428 
Fix linter
@aclum
Update test_imports.py
dac9765
@aclum
Update utils.py
7d6de52 
revert changes to make workflow_execution_dir a path or string.
@aclum
Update activity_mapper.py
55ba530 
fix url creation for multiple_object_mapper
@aclum
Update utils.py
d8e10be
@aclum
Update utils.py
0758b0a 
adding Path
@aclum
Update test_imports.py
4d74c24 
add assertion to to test url
@aclum
Update test_imports.py
d392f6b
@aclum
Update test_imports.py
7ea9062 
fix url assertion for multiple object mapper
@mbthornton-lbl mbthornton-lbl merged commit eb56382 into 252-workflow-automation-berkley-rc1 Oct 8, 2024
1 check passed
@mbthornton-lbl mbthornton-lbl deleted the 254-update-nmdc_automationimport_automation-to-be-compatible-with-berkley-metadata-and-endpoints branch October 8, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddd shreddd shreddd approved these changes

@mbthornton-lbl mbthornton-lbl mbthornton-lbl approved these changes

@scanon scanon Awaiting requested review from scanon

@kaijli kaijli Awaiting requested review from kaijli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update nmdc_automation.import_automation to be compatible with Berkley metadata and endpoints
3 participants
@aclum @shreddd @mbthornton-lbl