Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import automation logic when import files don't have upstream records. #260

Open
aclum opened this issue Oct 1, 2024 · 0 comments
Open
Labels

Comments

@aclum
Copy link
Contributor

aclum commented Oct 1, 2024

Discovered in testing of berkeley schema, specifically related to assert statements for test_workflow_execution_mapper in test_imports.py

The test has 4 files that pertain to two workflow executions but the test makes 4 workflow_execution_set records based on Import: true from the yaml file. These records will have an empty has_output. Technically the API still allows this but we shouldn't be doing this and if you fix #259 then the key wouldn't exist and then you'd get an error from the API about a missing required key. Low priority for now b/c It has not been a use case that we need to import annotations w/o upstream records but this could happen and we'd need to account for that. The code would need information about the has_output data object identifiers for the upstream workflow record and there is no logic to handle this right now.

@aclum aclum added the import label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant