Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SV_DispatchGrid semantic in a nested record #6928

Open
tcorringham opened this issue Sep 23, 2024 · 0 comments · May be fixed by #6931
Open

SV_DispatchGrid semantic in a nested record #6928

tcorringham opened this issue Sep 23, 2024 · 0 comments · May be fixed by #6931
Assignees
@tcorringham
Labels
bug Bug, regression, crash
Milestone
Next Release

Comments

@tcorringham
Copy link
Collaborator

Description
The SV_DispatchGrid DXIL metadata for a node input record is not generated in cases where:

  • the field with the SV_DispatchGrid semantic is in a nested record
  • the field with the SV_DispatchGrid semantic is in a record field
  • the field with the SV_DispatchGrid semantic is inherited from a base record
    Note that combinations of these scenarios are also possible.

Steps to Reproduce
https://godbolt.org/z/s5PdMbK95

Actual Behavior
The node input metadata record does not include a tag or pointer for a SV_DispatchGrid metadata record.

Environment

  • DXC version : (libdxcompiler.so: 1.8(dev;1-97af068e); libdxil.so: 1.8)
  • Host Operating System : Any (reproducible on both Windows and Linux)
@tcorringham tcorringham added bug Bug, regression, crash needs-triage Awaiting triage labels Sep 23, 2024
@tcorringham tcorringham self-assigned this Sep 23, 2024
tcorringham pushed a commit to tcorringham/DirectXShaderCompiler that referenced this issue Sep 24, 2024
Support SV_DispatchGrid semantic in a nested record
48b89fc 
The SV_DispatchGrid DXIL metadata for a node input record was not generated
in cases where:
- the field with the SV_DispatchGrid semantic was in a nested record
- the field with the SV_DispatchGrid semantic was in a record field
- the field with the SV_DispatchGrid semantic was inherited from a base record
- in any combinations of the above

Added FindDispatchGridSemantic() to be used by the AddHLSLNodeRecordTypeInfo()
function, and added a test case.

Fixes microsoft#6928
@tcorringham tcorringham linked a pull request Sep 24, 2024 that will close this issue
Open
@damyanp damyanp added this to the Next Release milestone Sep 24, 2024
@damyanp damyanp removed the needs-triage Awaiting triage label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcorringham tcorringham

Labels
bug Bug, regression, crash
Projects
HLSL Triage
Status: Triaged
Milestone
Next Release
Development

Successfully merging a pull request may close this issue.

Support SV_DispatchGrid semantic in a nested record tcorringham/DirectXShaderCompiler
2 participants
@damyanp @tcorringham