Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reassociate: add global reassociation algorithm (#6598) #6641

Open
wants to merge 1 commit into
base: release-1.8.2405
Choose a base branch
from

Conversation

lizhengxing
Copy link
Collaborator

This PR pulls the upstream change, Reassociate: add global reassociation algorithm
(llvm/llvm-project@b8a330c), into DXC with miminal changes.

For the code below:
foo = (a * b) * c
bar = (a * d) * c

As the upstream change states, it can identify the a*c is a common factor and redundant.

This is part 1 of the fix for #6593.

(cherry picked from commit 6f9c107)

This PR pulls the upstream change, Reassociate: add global reassociation
algorithm
(llvm/llvm-project@b8a330c),
into DXC with miminal changes.

For the code below:
  foo = (a * b) * c
  bar = (a * d) * c

As the upstream change states, it can identify the a*c is a common
factor and redundant.

This is part 1 of the fix for #6593.

(cherry picked from commit 6f9c107)
@lizhengxing lizhengxing requested a review from a team as a code owner May 21, 2024 23:04
Copy link
Contributor

@dmpots dmpots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pow2clk
pow2clk previously approved these changes May 22, 2024
Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait until we've resolved our internal ask mode discussion before completing this.

@pow2clk pow2clk self-requested a review May 22, 2024 19:08
@pow2clk pow2clk dismissed their stale review May 22, 2024 19:09

premature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants