[Validator] Check size of PSV. #6924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check size of PSV part matches the PSVVersion. Updated DxilPipelineStateValidation::ReadOrWrite to read based on initInfo.PSVVersion. And return fail when size mismatch in RWMode::Read. Fixes microsoft#6817
tex3d
requested changes
Sep 19, 2024
tex3d
reviewed
Sep 19, 2024
tex3d
reviewed
Sep 19, 2024
tex3d
reviewed
Sep 19, 2024
tex3d
requested changes
Sep 19, 2024
There was a problem hiding this comment.
In addition to the comments, we should be checking the string and index tables more thoroughly:
- check that string table is well formed - size is aligned, buffer ends with
\0 - check that accesses to string table entries are in-bounds, before using the value.
- check that accesses to index table entries are in-bounds, and that the (index+1)+size is within dword size of index table, before using the index array.
Then use PSVInitInfo to calculate correct size of PSV.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
tex3d
reviewed
Sep 23, 2024
tex3d
reviewed
Sep 23, 2024
tex3d
reviewed
Sep 23, 2024
tex3d
reviewed
Sep 23, 2024
tex3d
reviewed
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check size of PSV part matches the PSVVersion.
Updated DxilPipelineStateValidation::ReadOrWrite to read based on initInfo.PSVVersion.
And return fail when size mismatch in RWMode::Read.
Fixes #6817