Launch/Open/GoTo: Userfacing strings #32519

Jay-o-Way · 2024-04-18T13:02:59Z

Summary of the Pull Request

Split from #32351
Closely linked to #32514 and #32516 and #32450.

PR Checklist

Closes: "Open", "Launch", "Go to"... #30685
Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
Localization: All end user facing strings can be localized
Dev docs: Added/updated
Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Validation Steps Performed

Build

src/runner/Resources.resx

jaimecbernardo · 2024-04-18T15:20:11Z

Thanks for opening the PR :) Added some comments just from a quick glance.

Jay-o-Way · 2024-04-18T18:10:29Z

(off-topic) @ethanfangg I think the merge queue would be ideal for these 3 PRs + #32450

jaimecbernardo · 2024-05-10T12:53:20Z

In general looks good, but will revisit this series or PRs on .82 to not interfere with localization for Build right now, since it does change quite some strings. Hope this makes sense.

jaimecbernardo

Thank you for the contribution! I've commented on some nits.

src/modules/imageresizer/dll/ImageResizerExt.vcxproj

src/modules/previewpane/powerpreview/powerpreview.vcxproj

src/runner/Resources.resx

src/runner/runner.vcxproj

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

Jay-o-Way · 2024-05-29T14:58:15Z

All done!

jaimecbernardo

@Jay-o-Way , thanks for the changes. Just have one final nit. WDYT? Other than that, LGTM!

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>

crutkas

Doing a quick look, the problem with this style change is "does it make sense" and context of the change. I see designer changes which are auto generated files so those shouldn't be touched.

I do see value in these but each one requires a context of what and why that is happening. What are the UX implications of the change as well. (Screenshot)

src/modules/awake/Awake/Properties/Resources.Designer.cs

src/modules/PowerOCR/PowerOCR/Properties/Resources.Designer.cs

Jay-o-Way · 2024-06-17T18:43:07Z

@crutkas reverted Designer files ✔️

crutkas

big feedback for some of these is making sure they don't have unintended changes

src/modules/awake/Awake/Properties/Resources.resx

src/modules/fancyzones/editor/FancyZonesEditor/Properties/Resources.resx

src/runner/Resources.resx

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

crutkas · 2024-06-17T23:23:59Z

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

@@ -2027,10 +2027,10 @@ Made with 💗 by Microsoft and the PowerToys community.</value>
    <value>Getting started</value>
  </data>
  <data name="Oobe_Launch.Text" xml:space="preserve">
-    <value>Launch</value>
+    <value>Open</value>


where is this used

I think this is a dead string
https://github.com/search?q=repo%3Amicrosoft%2FPowerToys+Oobe_Launch&type=code

You are correct. But that's off-topic. Niels has already called out to look for dead strings in #32479.

crutkas · 2024-06-17T23:25:47Z

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

@@ -831,7 +831,7 @@
    <value>Try this if there are issues with the shortcut (PowerToys Run might not get focus when triggered from an elevated window)</value>
  </data>
  <data name="PowerLauncher_ClearInputOnLaunch.Content" xml:space="preserve">
-    <value>Clear the previous query on launch</value>
+    <value>Clear the previous query on opening</value>


I don't agree 'opening' is the correct verb here. Invoke could be an alternative but PT Run is a surface that is temporal.

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

crutkas

Tweak the 2 reverts and accept the suggestion and i'll approve.

src/modules/awake/Awake/Properties/Resources.resx

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

src/modules/fancyzones/editor/FancyZonesEditor/Properties/Resources.resx

src/runner/Resources.resx

src/modules/awake/Awake/Properties/Resources.resx

crutkas · 2024-06-19T16:24:13Z

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

@@ -2027,10 +2027,10 @@ Made with 💗 by Microsoft and the PowerToys community.</value>
    <value>Getting started</value>
  </data>
  <data name="Oobe_Launch.Text" xml:space="preserve">
-    <value>Launch</value>
+    <value>Open</value>


I think this is a dead string
https://github.com/search?q=repo%3Amicrosoft%2FPowerToys+Oobe_Launch&type=code

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

This was referenced Apr 18, 2024

Launch/Open/GoTo: Comments #32514

Open

Launch/Open/GoTo: Code #32516

Open

Jay-o-Way requested a review from crutkas April 18, 2024 13:20

Jay-o-Way added this to the PowerToys 0.81 milestone Apr 18, 2024

Jay-o-Way marked this pull request as ready for review April 18, 2024 13:21

jaimecbernardo reviewed Apr 18, 2024

View reviewed changes

src/runner/Resources.resx Outdated Show resolved Hide resolved

jaimecbernardo reviewed Apr 18, 2024

View reviewed changes

src/runner/Resources.resx Outdated Show resolved Hide resolved

Jay-o-Way changed the title ~~Launch open go: Userfacing strings~~ Launch/Open/GoTo: Userfacing strings Apr 22, 2024

jaimecbernardo added the revisit-0.82.0 label May 10, 2024

jaimecbernardo requested changes May 29, 2024

View reviewed changes

Jay-o-Way removed this from the PowerToys 0.81 milestone May 29, 2024

Jay-o-Way requested a review from jaimecbernardo May 31, 2024 13:09

Jay-o-Way added 7 commits May 31, 2024 17:44

launch - open

e239b9c

tray menu strings

fa78dc5

exit - close

c95d62a

open - go to

e7a1b7d

Flyout strings

e403ca5

Settings

d900c0d

Feedback: revert small things

2e8656f

Jay-o-Way force-pushed the launch-open-go-userfacing branch from 8128343 to 2e8656f Compare May 31, 2024 15:44

jaimecbernardo requested changes Jun 17, 2024

View reviewed changes

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw Outdated Show resolved Hide resolved

open versus run

c6b9e3b

Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>

crutkas requested changes Jun 17, 2024

View reviewed changes

src/modules/awake/Awake/Properties/Resources.Designer.cs Outdated Show resolved Hide resolved

src/modules/PowerOCR/PowerOCR/Properties/Resources.Designer.cs Outdated Show resolved Hide resolved

Revert Designer.cs files

4cb6bfd

crutkas requested changes Jun 17, 2024

View reviewed changes

crutkas requested changes Jun 19, 2024

View reviewed changes

adress feedback

5351a0e

Jay-o-Way requested review from jaimecbernardo and crutkas July 4, 2024 23:17

Jay-o-Way requested a review from ethanfangg August 1, 2024 11:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Launch/Open/GoTo: Userfacing strings #32519

Launch/Open/GoTo: Userfacing strings #32519

Jay-o-Way commented Apr 18, 2024 •

edited

Loading

jaimecbernardo commented Apr 18, 2024

Jay-o-Way commented Apr 18, 2024 •

edited

Loading

jaimecbernardo commented May 10, 2024

jaimecbernardo left a comment

Jay-o-Way commented May 29, 2024

jaimecbernardo left a comment

crutkas left a comment

Jay-o-Way commented Jun 17, 2024

crutkas left a comment

crutkas Jun 17, 2024

crutkas Jun 19, 2024

Jay-o-Way Jun 27, 2024

crutkas Jun 17, 2024

crutkas left a comment

crutkas Jun 19, 2024

Launch/Open/GoTo: Userfacing strings #32519

Are you sure you want to change the base?

Launch/Open/GoTo: Userfacing strings #32519

Conversation

Jay-o-Way commented Apr 18, 2024 • edited Loading

Summary of the Pull Request

PR Checklist

Validation Steps Performed

jaimecbernardo commented Apr 18, 2024

Jay-o-Way commented Apr 18, 2024 • edited Loading

jaimecbernardo commented May 10, 2024

jaimecbernardo left a comment

Choose a reason for hiding this comment

Jay-o-Way commented May 29, 2024

jaimecbernardo left a comment

Choose a reason for hiding this comment

crutkas left a comment

Choose a reason for hiding this comment

Jay-o-Way commented Jun 17, 2024

crutkas left a comment

Choose a reason for hiding this comment

crutkas Jun 17, 2024

Choose a reason for hiding this comment

crutkas Jun 19, 2024

Choose a reason for hiding this comment

Jay-o-Way Jun 27, 2024

Choose a reason for hiding this comment

crutkas Jun 17, 2024

Choose a reason for hiding this comment

crutkas left a comment

Choose a reason for hiding this comment

crutkas Jun 19, 2024

Choose a reason for hiding this comment

Jay-o-Way commented Apr 18, 2024 •

edited

Loading

Jay-o-Way commented Apr 18, 2024 •

edited

Loading