Do not merge: Dummy test change #12315
Conversation
|
Are there any plans to have the Sha256 field be anything (a URL perhaps?) but a string of the form of Part of our build process creates a And it would be great to be able to have the modern setup point to: |
Not at this time. The idea behind that hash is to guarantee that the distribution doesn't change after it's been added to the manifest, so having a remote file containing the hash wouldn't have that guarantee unfortunately. |
Is that some kind of internal check? Maybe something is auto-checked/validated before a PR would be accepted? Our build service can build the tarball and hash it and even host both files. So it's a bummer if I'd still need to do point-in-time uploads w/ a simple hash; I don't really see the value in that, especially compared to the Store where it felt like it made more sense since we signed the .appx, then Microsoft signed it and there were the other elements related to the Store (and presentation). |
Completely understood. This hash is here to prevent potential supply chain attacks so it would need to be directly in the manifest. Would automating the generation of the pull request be an option for you ? We could potentially have a script hosted in this repo that could do the hashing / generating of the updated manifest and creation of the pull request. If you could call it from your build pipeline that would remove the need for manual work at least |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for your contribution to WSL.
The following fatal errors have been found in this pull request:
- test/test-v1: File "./etc/wsl-distribution.conf" not found in tar
The following suggestions have been found in this pull request:
- test/test-v1: file: "./etc/wsl-distribution.conf" has unexpected mode: 0o755 (expected: ['0o664', '0o644'])
- test/test-v1: value for oobe.command is not under /usr/lib/wsl: "/oobe.sh"
- test/test-v1: file: "./debian.ico" has unexpected mode: 0o755 (expected: ['0o660', '0o640'])
- test/test-v1: value for shortcut.icon is not under /usr/lib/wsl: "/debian.ico"
- test/test-v1: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
- test/test-v1: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
- test/test-v1: Found discouraged system unit: /etc/systemd/system/multi-user.target.wants/networking.service
- test/test-v1: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
- test/test-v1: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
- test/test-v1: Found discouraged system unit: /etc/systemd/system/multi-user.target.wants/systemd-resolved.service
- test/test-v1: Found discouraged system unit: /etc/systemd/system/multi-user.target.wants/systemd-networkd.service
There was a problem hiding this comment.
Thank you for your contribution to WSL.
The following fatal errors have been found in this pull request:
- test/test-v1: File "./etc/wsl-distribution.conf" not found in tar
The following suggestions have been found in this pull request:
- test/test-v1: file: "./etc/wsl-distribution.conf" has unexpected mode: 0o755 (expected: ['0o664', '0o644'])
- test/test-v1: value for oobe.command is not under /usr/lib/wsl: "/oobe.sh"
- test/test-v1: file: "./debian.ico" has unexpected mode: 0o755 (expected: ['0o660', '0o640'])
- test/test-v1: value for shortcut.icon is not under /usr/lib/wsl: "/debian.ico"
- test/test-v1: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
- test/test-v1: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
- test/test-v1: Found discouraged system unit: /etc/systemd/system/multi-user.target.wants/networking.service
- test/test-v1: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
- test/test-v1: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
- test/test-v1: Found discouraged system unit: /etc/systemd/system/multi-user.target.wants/systemd-resolved.service
- test/test-v1: Found discouraged system unit: /etc/systemd/system/multi-user.target.wants/systemd-networkd.service
No description provided.