Generator does not handle empty strings in enum fields (Go)

[matt-tyler-qoria]

We are trying to generate a Go client from the Clever API openapi specification available at the below link:

https://github.com/Clever/swagger-api/blob/master/v3.0.yml

This includes many enum definitions that follow this basic pattern.

gender:
  enum:
  - M
  - F
  - X
  - ""
  type: string

This is resulting in the following generated code

const (
    M_STUDENT_GENDER Student_gender = iota
    F_STUDENT_GENDER
    X_STUDENT_GENDER
)

func (i Student_gender) String() string {
    return []string{"M", "F", "X"}[i]
}
func ParseStudent_gender(v string) (any, error) {
    result := M_STUDENT_GENDER
    switch v {
        case "M":
            result = M_STUDENT_GENDER
        case "F":
            result = F_STUDENT_GENDER
        case "X":
            result = X_STUDENT_GENDER
        default:
            return 0, errors.New("Unknown Student_gender value: " + v)
    }
    return &result, nil
}

This results in the valid value of "" being interpreted as an error.

[andrueastman]

Thanks for raising this @matt-tyler-qoria

Looks like the generator prevents the addition of enum options if the enum option value or name is an empty string.

To fix this we need to

• remove the empty string filter at
  

  kiota/src/Kiota.Builder/KiotaBuilder.cs

  Line 1752 in 7e0a4c0

  .Where(static x => !x.Value.Equals("null", StringComparison.OrdinalIgnoreCase) && !string.IsNullOrEmpty(x.Value))

• initialize a default name for option when the name is empty too at

  kiota/src/Kiota.Builder/KiotaBuilder.cs

  Line 1760 in 7e0a4c0

  Name = (optionDescription?.Name is string name && !string.IsNullOrEmpty(name) ?

  so that its not removed
• Add unit tests to validate/catch the change

Any chance you'd be willing to submit a PR with a unit test to fix this?

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.