Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe approvers does not work like ADO #31

Open
chris-oo opened this issue Aug 8, 2024 · 1 comment
Open

unsafe approvers does not work like ADO #31

chris-oo opened this issue Aug 8, 2024 · 1 comment
Labels
CI Improvements or additions to our CI setup outside of flowey

Comments

@chris-oo
Copy link
Member

chris-oo commented Aug 8, 2024

Anyone in the hvlite team can signoff on any PR, because github does not have a stock way of enforcing every required reviewer signs off, only that a set number of reviewers sign off. See https://github.com/orgs/community/discussions/23765

One way of accomplishing this could be some more github actions that assign a unsafe-reviewers-required label, and unsafe-reviewers-approved labels that are driven by those teams.

@chris-oo
Copy link
Member Author

chris-oo commented Aug 8, 2024

Actually, the right thing to do is have the unsafe-reviewers.py script to validate that someone from the unsafe reviewers signed off, and mark red otherwise.

@benhillis benhillis transferred this issue from another repository Oct 7, 2024
@smalis-msft smalis-msft added the CI Improvements or additions to our CI setup outside of flowey label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Improvements or additions to our CI setup outside of flowey
Projects
None yet
Development

No branches or pull requests

2 participants