How to correctly use filter

[tiborrr]

Hello,

Really like the SDK thusfar, but I do have a question.

I am trying to use the filter parameters when getting attachments from an email but it does not work. I am expecting only isInline=False attachments, but also receive attachment that are inlined. I do not know if this is a bug of if I am using the sdk wrong.

This is what I am trying to do but does not work

        query_params = (
            AttachmentsRequestBuilder.AttachmentsRequestBuilderGetQueryParameters(
                filter="isInline eq false"
            )
        )
        request_config = (
            AttachmentsRequestBuilder.AttachmentsRequestBuilderGetRequestConfiguration(
                query_parameters=query_params
            )
        )

Problematic code block:

    for message in messages:
        if message.id is None:
            raise ValueError(f"No message id found for {message}")
        if message.has_attachments is False:
            result.append((message, []))
            continue
        query_params = (
            AttachmentsRequestBuilder.AttachmentsRequestBuilderGetQueryParameters(
                filter="isInline eq false"
            )
        )
        request_config = AttachmentsRequestBuilder.AttachmentsRequestBuilderGetRequestConfiguration(
            query_parameters=query_params
        )
        message_query = folder_query.messages.by_message_id(message.id)
        attachments: List[FileAttachment] = []
        while True:
            attachments_response = await message_query.attachments.get(request_config)
            if attachments_response is None:
                raise ValueError(f"Error in API response for getting attachments for {message}")
            if attachments_response.value is not None:
                attachments.extend(attachments_response.value) # type: ignore
            if attachments_response.odata_next_link is None:
                break

        result.append((message, attachments))

Full implementation for reference and context:

import asyncio
from typing import Any, Dict, List, Tuple
from azure.identity import ClientSecretCredential
from msgraph import GraphServiceClient
from msgraph.generated.models.message import Message
from msgraph.generated.models.attachment import Attachment
from msgraph.generated.models.file_attachment import FileAttachment
from msgraph.generated.users.item.mail_folders.item.messages.messages_request_builder import MessagesRequestBuilder
from msgraph.generated.users.item.mail_folders.item.messages.item.attachments.attachments_request_builder import (
    AttachmentsRequestBuilder,
)
from app_config import AZURE_CLIENT_ID, AZURE_CLIENT_SECRET, AZURE_TENANT_ID, BATCH_SIZE, ENVIRONMENT, MAILBOXES, MAILBOXES_TO_PROCESS

credential = ClientSecretCredential(
    AZURE_TENANT_ID, AZURE_CLIENT_ID, AZURE_CLIENT_SECRET
)
scopes = ["https://graph.microsoft.com/.default"]
client = GraphServiceClient(credentials=credential, scopes=scopes)


async def get_mails_from_mailbox(
    mailbox_name: str,
) -> List[Tuple[Message, List[FileAttachment]]]:
    # Get the messages from the mailbox of the specified user
    upn = MAILBOXES[mailbox_name]["upn"]
    if ENVIRONMENT == "PROD":
        folder_id = MAILBOXES[mailbox_name]["inbox"]
    else:
        folder_id = MAILBOXES[mailbox_name]["test_inbox"]
    query_options = MessagesRequestBuilder.MessagesRequestBuilderGetQueryParameters(
        top=BATCH_SIZE, orderby=["receivedDateTime asc"]
    )
    request_options = (
        MessagesRequestBuilder.MessagesRequestBuilderGetRequestConfiguration(
            query_parameters=query_options
        )
    )
    user_query = client.users.by_user_id(upn)
    folder_query = user_query.mail_folders.by_mail_folder_id(folder_id)
    messages: List[Message] = []
    while True:
        messages_response = await folder_query.messages.get(request_options)
        if messages_response is None:
            raise ValueError(f"Error in API response for getting messages for {mailbox_name}")
        if messages_response.value is not None:
            messages.extend(messages_response.value)
        if messages_response.odata_next_link is None:
            break

    result: List[Tuple[Message, List[FileAttachment]]] = []

    for message in messages:
        if message.id is None:
            raise ValueError(f"No message id found for {message}")
        if message.has_attachments is False:
            result.append((message, []))
            continue
        query_params = (
            AttachmentsRequestBuilder.AttachmentsRequestBuilderGetQueryParameters(
                filter="isInline eq false"
            )
        )
        request_config = AttachmentsRequestBuilder.AttachmentsRequestBuilderGetRequestConfiguration(
            query_parameters=query_params
        )
        message_query = folder_query.messages.by_message_id(message.id)
        attachments: List[FileAttachment] = []
        while True:
            attachments_response = await message_query.attachments.get(request_config)
            if attachments_response is None:
                raise ValueError(f"Error in API response for getting attachments for {message}")
            if attachments_response.value is not None:
                attachments.extend(attachments_response.value) # type: ignore
            if attachments_response.odata_next_link is None:
                break

        result.append((message, attachments))

    return result


async def get_mails_async() -> List[Tuple[Message, List[FileAttachment]]]:
    tasks = [get_mails_from_mailbox(upn) for upn in MAILBOXES_TO_PROCESS]
    result = await asyncio.gather(*tasks)
    return result


def get_mails() -> List[Tuple[Message, List[FileAttachment]]]:
    return asyncio.run(get_mails_async())