Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc_open hangs - for few options (--orientation "landscape") #60

Open
sujith-entreda opened this issue Dec 2, 2022 · 1 comment
Open

Comments

@sujith-entreda
Copy link

sujith-entreda commented Dec 2, 2022

$this->_stdErr = stream_get_contents($pipes[2]);
$this->_stdOut = stream_get_contents($pipes[1]);

Environment: Windows XAMPP

Have to swap these two lines,
https://stackoverflow.com/questions/31194152/proc-open-hangs-when-trying-to-read-from-a-stream

@sujith-entreda sujith-entreda changed the title proc_open hangs proc_open hangs - for few options (--orientation "landscape") Dec 2, 2022
@mikehaertl
Copy link
Owner

There's some history to the current code: your change was suggested before in #20 and lead to new problems in #21. So I'm a bit hesitant to ever change this again.

On the other hand #20 resulted in a big rewrite of proc_open() in non-blocking mode which fixed most of the hanging issues. It is not an option on windows systems but most developers probably use Linux anyway and will not be affected by the change.

So we could probably give this change a try - but I already see more new issues popping up complaining that things now don't work as before on Windows.

Sidenote: I know it's provocative but IMO switching to Linux for development or using Docker to run PHP would save you a lot of pain. In my experience PHP and Windows never were friends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants