Adding Laplace wrappers #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Project.toml
Note: * We only test potential evaluations (i.e. we do NOT test gradients and Hessians - This can be fixed by wrapping the direct function from fmm2d)
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Fixing sign in Laplace definition so that it follows that of Helmholtz
Making `hfmm2d` follow `lfmm2d`
mipals
commented
Feb 21, 2024
There was a problem hiding this comment.
@JuliaRegistrator register
Release notes:
- Fixed bug in Hessian computations (FMM2D returns a 3-vector and not a 4-vector)
- Upgraded the binaries (FMM2D_jll v1 -> v1.1)
- Added wrapper for Laplace. Note that
cfmm2dis experimental
Repository owner
deleted a comment from
JuliaRegistrator
Feb 21, 2024
Repository owner
deleted a comment from
JuliaRegistrator
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lfmm2dfor complex charges andrfmm2dfor real charges (this can probably be made easier in the future)