Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freyr downloading song that has gameplay audio #651

Open
Thiccolas3245 opened this issue Jan 29, 2024 · 2 comments
Open

freyr downloading song that has gameplay audio #651

Thiccolas3245 opened this issue Jan 29, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Thiccolas3245
Copy link

Thiccolas3245 commented Jan 29, 2024

for some reason, when I've downloaded certain tracks that are from video games, freyr gives me tracks that have gameplay audio in them

examples:
Camellia - Tempo Katana -
Spotify Link: https://open.spotify.com/album/3LrSsAtkvSfVdxabXiInCR?si=xi60lCjXTNy78T7H8pxx6Q

Camellia - LORELEI
Spotify Link: https://open.spotify.com/album/6OzPAnOQtqvMV5wcrR3oG6?si=_qJLX1pSTJ-Nhl5PZQ58_Q

What freyr downloaded (for me at least): https://drive.google.com/drive/folders/1VZRM1dnO3HrQAT_cFCS4pjTZz1RzLoMS?usp=sharing

@Thiccolas3245
Copy link
Author

other than that though, for most, if not all other songs it works great!

@miraclx
Copy link
Owner

miraclx commented Jan 29, 2024

I'll take a look, thanks for filing. And thanks for including the output tracks - helped extract a dump of the metadata freyr embedded to see the source audio feed. I'll look into why this seemed to have been weighted to be the most accurate source for this track.

AtomicParsley metadata dump from the tracks

Camellia - LORELEI

$ AtomicParsley "01 Lorelei.m4a" -t
Atom "©too" contains: freyr-js cli v0.10.3
Atom "©nam" contains: Lorelei
Atom "©ART" contains: Camellia
Atom "©alb" contains: Lorelei
Atom "trkn" contains: 1 of 1
Atom "disk" contains: 1 of 1
Atom "©day" contains: 2023-02-24
Atom "----" [com.apple.iTunes;MEDIA] contains: Digital Media
Atom "----" [com.apple.iTunes;ISRC] contains: TCAGW2337725
Atom "----" [com.apple.iTunes;ARTISTS] contains: Camellia
Atom "----" [com.apple.iTunes;LABEL] contains: Camellia
Atom "----" [com.apple.iTunes;SOURCE] contains: Spotify: spotify:track:7cEZld0rEQoHv1wcdnoOj1
Atom "----" [com.apple.iTunes;PROVIDER] contains: YouTube Music: 2ImyBNM4fw0
Atom "rtng" contains: Inoffensive
Atom "stik" contains: Normal
Atom "aART" contains: Camellia
Atom "purd" contains: 2024-01-29T02:17:24Z
Atom "apID" contains: cli@freyr.git
Atom "cprt" contains: 2023 Camellia
Atom "©enc" contains: d3vc0dr
Atom "sonm" contains: Lorelei
Atom "soal" contains: Lorelei
Atom "soar" contains: Camellia
Atom "covr" contains: 1 piece of artwork

Camellia - Tempo Katana

$ AtomicParsley "01 Tempo-Katana.m4a" -t
Atom "©too" contains: freyr-js cli v0.10.3
Atom "©nam" contains: Tempo-Katana
Atom "©ART" contains: Camellia
Atom "©alb" contains: Tempo-Katana
Atom "trkn" contains: 1 of 1
Atom "disk" contains: 1 of 1
Atom "©day" contains: 2023-12-11
Atom "----" [com.apple.iTunes;MEDIA] contains: Digital Media
Atom "----" [com.apple.iTunes;ISRC] contains: QZWFL2393975
Atom "----" [com.apple.iTunes;ARTISTS] contains: Camellia
Atom "----" [com.apple.iTunes;LABEL] contains: Beat Games
Atom "----" [com.apple.iTunes;SOURCE] contains: Spotify: spotify:track:18IACsfTno406odM9xBavT
Atom "----" [com.apple.iTunes;PROVIDER] contains: YouTube Music: qjoXBlx6hSc
Atom "rtng" contains: Inoffensive
Atom "stik" contains: Normal
Atom "aART" contains: Camellia
Atom "purd" contains: 2024-01-29T02:17:01Z
Atom "apID" contains: cli@freyr.git
Atom "cprt" contains: 2023 Beat Games
Atom "©enc" contains: d3vc0dr
Atom "sonm" contains: Tempo-Katana
Atom "soal" contains: Tempo-Katana
Atom "soar" contains: Camellia
Atom "covr" contains: 1 piece of artwork

@miraclx miraclx added bug Something isn't working good first issue Good for newcomers labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants