Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of malformed headers fails silently #1032

Open
askvortsov1 opened this issue Jun 5, 2024 · 3 comments
Open

Parsing of malformed headers fails silently #1032

askvortsov1 opened this issue Jun 5, 2024 · 3 comments

Comments

@askvortsov1
Copy link

The header parsing implementation returns early if it encounters a malformed header. It doesn't communicate any error info to the caller, and presumably the unparsed lines are interpreted as part of the body.

@Athishpranav2003
Copy link

I guess i can check this out in my free time

@Athishpranav2003
Copy link

@askvortsov1 can you list some kinda malformed headers for reference?

@Athishpranav2003
Copy link

The request/status line and headers must all end with <CR><LF> (that is, a [carriage return](https://en.wikipedia.org/wiki/Carriage_return) followed by a [line feed](https://en.wikipedia.org/wiki/Line_feed)). The empty line must consist of only <CR><LF> and no other [whitespace](https://en.wikipedia.org/wiki/Whitespace_(computer_science)).

I got this in wiki and few more places(which referenced RFCs. I guess i will go with this as the standard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants