Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punycode features? #65

Open
dsheets opened this issue Mar 30, 2015 · 4 comments
Open

Punycode features? #65

dsheets opened this issue Mar 30, 2015 · 4 comments
Labels
Milestone

Comments

@dsheets
Copy link
Member

dsheets commented Mar 30, 2015

It's frightening but it does exist. :-(

See https://tools.ietf.org/html/rfc3492 and https://tools.ietf.org/html/rfc5891.

This might want to be a codec lib that we depend on in some future utopia.

@hannesm
Copy link
Member

hannesm commented Sep 27, 2016

some lib (not yet packaged, needs mli and tests) appeared https://github.com/cfcs/ocaml-punycode

avsm pushed a commit to avsm/ocaml-dns that referenced this issue Jun 23, 2017
@avsm
Copy link
Member

avsm commented May 9, 2019

@hannesm @cfcs is this in scope for integration now that we use domain-names here?

@avsm avsm added this to the 2.0.0 milestone May 9, 2019
@hannesm
Copy link
Member

hannesm commented May 9, 2019

it should not need any changes to dns itself (ok, maybe to the client code), but instead some transformation before passing the request to the internet via the above linked punycode library

@cfcs
Copy link
Contributor

cfcs commented May 9, 2019

The library now has tests and docstrings, and I think it should work pretty well now, at least I haven't been able to find misbehaviour.

Due to phishing and so on I'm a little bit concerned about transparently encoding Punycode names from unicode strings, see:
cfcs/ocaml-punycode#6

I'm not 100% up to date on what countermeasures browsers deploy to prevent stuff like this, but I think a common one is to complain if the unicode string contains characters from mixed unicode character planes, ie all-cyrillic or all-latin is fine, but mixed cyrillic and latin is rejected. The Wikipedia article referenced in the issue has some more details.

RyanGibb pushed a commit to RyanGibb/ocaml-dns that referenced this issue Sep 26, 2022
fix zarith opam (for normal installation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants